[quality] cover zero-hit funcs across indexformula, store, registry, news, api - #158
Merged
Merged
Conversation
… passes, news async, match notifier Adds unit tests for functions previously at 0% coverage: - indexformula.Activity (package 50% -> 100%) - store: Idea.OfferTo, Idea.HasPassed, ValidationError.Error, ListAll, ListSettled (79.2% -> 86.4%) - registry: RepoProfile.HasPassed, AddPassedIdea incl. persistence, UniqueRepoTickerSymbol two-letter/full-scan/exhaustion fallbacks (78.6% -> 87.3%) - news: NewGenerator, RefreshAsync nil-guards + in-flight dedup, truncateOneLine edge cases (73.7% -> 85.3%) - api: MatchNotifier.NewMatch privacy contract - private ideas never notify repo owners (75.5% -> 76.2%) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: sec-check <sec-check@hive.kubestellar.io>
kubestellar-prow
Bot
added
the
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubestellar-prow
Bot
added
the
size/L
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Covers a cluster of functions that had 0% coverage, plus low-coverage fallback branches, across five packages:
ActivityRepoProfile.HasPassed,AddPassedIdea(not-found/forbidden/idempotent/persistence),UniqueRepoTickerSymboltwo-letter-tail, full-scan, and exhaustion-panic fallbacksIdea.OfferTo(incl. aliasing contract),Idea.HasPassed,ValidationError.Error,ListAll,ListSettledNewGenerator,RefreshAsyncnil-guards + in-flight per-repo dedup (blocking fetcher),truncateOneLineedge casesMatchNotifier.NewMatch— locks in the privacy contract that private ideas never notify repo ownersNotable behavior now guarded by tests:
NewMatchon a private idea must notify only the idea author (docs promise this; nothing tested it).ListSettledmust return only settled ideas and an empty non-nil slice otherwise (public credit wall surface).AddPassedIdeaswipes survive registry reopen (persisted, idempotent, owner-only).RefreshAsyncdrops refresh requests for repos already in flight.Test-only change;
go vet ./pkg/...clean, fullgo test ./...passes.Filed by quality agent (ACMM L4/L6 — full mode)
— hive: agent=quality backend=copilot model=claude-fable-5 copilot=1.0.88