HP-2858: modernized Modal PlayWright class for easier using

[VadymHrechukha]

Summary by CodeRabbit

• Tests
  • Updated modal test helper initialization to modify how modals are targeted during testing.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

Modal initialization in two test helper methods has been refactored to remove explicit modal ID selectors. The code now constructs Modal objects using only the page parameter instead of targeting specific modals by [id="bulk-enable-block-modal"] and [id="bulk-disable-block-modal"]. Subsequent field and button interactions remain unchanged.

Changes

Cohort / File(s)	Summary
Test Helper Modal Initialization tests/playwright/helper/HDomainHelper.ts	Two Modal constructor calls simplified by removing explicit modal ID selectors; Modal initialization now uses page-only parameter in bulk enable and bulk disable methods

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

• SilverFire

Poem

🐰 A modal shift, so swift and clean,
Remove the selectors from the scene,
Page alone shall light the way,
Tests grow broader, come what may!
✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: modernizing the Modal PlayWright class to improve usability, which aligns with the removal of specific modal selectors in favor of a more flexible initialization approach.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 36c7849 and 938ac5e.

📒 Files selected for processing (1)

• tests/playwright/helper/HDomainHelper.ts

🔇 Additional comments (1)

tests/playwright/helper/HDomainHelper.ts (1)

37-37: Verify Modal class implementation in @hipanel-core package.

The Modal is now instantiated with only the page parameter (previously included an explicit selector like [id="bulk-enable-block-modal"]). Since Modal is imported from the external @hipanel-core/shared/ui/components package, verify in that package that:

1. The Modal class constructor has been updated to support initialization without an explicit selector parameter
2. Modal correctly auto-detects and interacts with the intended modal when no selector is provided
3. Test scenarios don't involve multiple modals being present simultaneously, which could cause incorrect modal interaction

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}