Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64.
A frame copied into the reorder pool lost its Vulkan image when its decoder was dropped, even though the frame was still alive, so reading it afterwards crashed. The docs promise the image stays valid for as long as the frame lives, and DPB frames already keep theirs alive.
Pool images now use the same reference-counted owner as DPB images (
DpbImage). Buffered and handed-out frames each hold a reference; the pool reuses an image once it holds the only one, and the last owner destroys it. That replaces the pool's free/buffered/handed-out states and release queue, so the change removes more than it adds.Testing (RTX 4080 SUPER, NVIDIA 620.70.06)
pooled_frame_outlives_decoder: downloads both planes of a copied frame, drops the decoder, downloads them again and compares, then checks the allocation is released with the frame. It crashes without the fix.drop_non_dropwarnings as unmodifiedmain.cargo test -- --ignoredpasses, including all 35 decode-stream tests.🤖 Created with GPT-6.2 Astra in Codex and reviewed with Claude Opus 5.5 in Claude Code.