Repository navigation
RFI Recovery Frames - #62
Merged
Merged
Conversation
Owner
|
Nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets a streaming host recover from a lost frame without an IDR, and tell the client which frame recovers.
EncodeConfig::with_active_reference_frames(n): predict fromnreferences while keeping the whole DPB window for invalidation. On RADV, H.264 takes about 75% longer per frame with two references than with one.EncodedPacket::is_recovery_frame: set on the first frame after an invalidation that recovers without a keyframe (Moonlight's frame type 5).Encoder::invalidate_reference_framesnow returnsbool:falsemeans no reference survived and the next frame is an IDR. Needs a 0.13.0 release.Testing
tests/rfi.rsupdated and passing on a 7900 XTX (RADV);b_framesadjusted for the new API.rate_control_changes(H.264 + B-frames) fails, but identically on plainmain(92c6275), so it's not from this change.Known limit
AV1's window is capped at 7 references (
NUM_REF_FRAMES= 8), about 58 ms at 120 fps, so at higher RTT AV1 falls back to IDRs. Spacing the older AV1 references out is a possible follow-up, not in this PR.