Windows update-progress console probe on CI (#381) + hold pushes behind background sub-agents (#389) - #398
Merged
Conversation
#381) The in-place progress redraw on Windows depends on a JNA GetConsoleMode(stderr) probe that was written without a Windows machine. If it silently fails, the verdict falls back to plain scrolling lines — the exact symptom users report. Run it in child JVMs with stderr on a console (2>CON) and on NUL in the existing windows-latest CI job. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
) Each background sub-agent that returns wakes the main agent for another turn, and every turn result pushed "complete" — one notification per returning agent. A clean result while background sub-agents or workflows still run is now held and replaced by the turn that ends with none left. Errors are never held; background shells/monitors never hold (a dev server may never finish). Fallbacks: release 60s after the last agent settles with no continuation turn running, a 30-min backstop, and the process-death path. Android: enable vibration on newly created notification channels. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…381) cmd's 2>CON opens the console write-only; GetConsoleMode needs GENERIC_READ, so the first CI run reported false for a handle no terminal hands out. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
heypandax
marked this pull request as ready for review
September 24, 2026 16:52
This was referenced Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#381 — Windows update progress still scrolls line by line
The 2.1.2 package contains the in-place redraw. Progress is drawn by the updater that is currently running, though. 2.1.2 is the latest release, so any download progress a user sees now came from a ≤2.1.1 updater, and those versions always print lines on Windows. The redraw first shows up on the 2.1.2 → next update.
The redraw depends on a JNA
GetConsoleMode(stderr)probe that has never run on real Windows. If that call fails, it quietly falls back to plain lines. This PR addsUpdateProgressWinConsoleTestto the existingwindows-latestjob (*WinConsole*), which checks that:2>CONdecides to redraw in place;2>NULkeeps plain lines.#389 — one notification per background sub-agent
Each background sub-agent that returns wakes the main agent for another turn, and each turn result pushed "complete". Now, when a clean result arrives while background sub-agents or Workflow runs are still RUNNING, its push is held. The turn that ends with none left pushes instead.
iOS already sends
sound: default, so a banner-only alert there points at device settings (Sounds / Focus / Scheduled Summary). The push diagnostics'soundSettingcan confirm this.Verification
:daemon:test: 2355 tests, all pass exceptAgentProcessShutdownTest, which failed once under full-suite load (exit 141 instead of 137). It passed 5/5 when rerun on its own.ConversationPushTestcases: fan-out gives one push, failures are pushed immediately, a background shell does not hold, and both the settle and backstop fallbacks fire. With the hold disabled, 2 of them fail as expected.🤖 Generated with Claude Code