Skip to content

fix(ringer): restore distinct mode vibration patterns - #75

Draft
heykay-47 wants to merge 1 commit into
mainfrom
fix/73-ringer-vibration
Draft

heykay-47 wants to merge 1 commit into
mainfrom
fix/73-ringer-vibration

Conversation

@heykay-47

@heykay-47 heykay-47 commented Nov 16, 2026 •

Copy link
Copy Markdown
Owner

Summary

Ring     → unchanged 400 ms buzz
Vibrate  → 3 click primitives, 70 ms gaps (Android 11+ when supported)
           otherwise the original 0,40,90,40,90,40 waveform
Silent   → one heavy click instead of a light tick

Uses public Android haptic effects, not the private ColorOS patterns.

Fixes #73

Evidence

  • Before (source): Vibrate used two 150 ms pulses separated by 200 ms; Silent used EFFECT_TICK.
    After (source): Vibrate uses a capability-checked triple click with a triple-pulse fallback; Silent uses EFFECT_HEAVY_CLICK.
  • git diff --check passed.
  • PR CI passed build, permissions and reproducibility; CodeQL also passed.
  • Release-signed test build passed, including 148 unit tests (0 failures/errors/skips). Downloaded APK certificate matches the pinned release certificate.
  • Advisory lint reports StartActivityAndCollapseDeprecated in unchanged SnapTileService.kt:80; no lint findings on the changed haptic code.
  • No mocked vibration tests added: they cannot establish what the effects feel like.
  • Physical testing not run. Keep this PR as a draft until the maintainer confirms Ring, Vibrate and Silent are distinguishable on the Find X9. OnePlus 15R and Android 10 fallback also remain untested.

Merge Danger

Door: two-way

Feedback only; no settings-format, mode-transition, permission or dependency changes.

Blast Radius: haptics

Hardware and firmware decide the final feel. The waveform fallback may still feel weak on some phones.

Use three supported click primitives for Vibrate, with the original triple-pulse waveform as a fallback. Give Silent a heavy click and keep Ring's long buzz.

Fixes #73
@coderabbitai

coderabbitai Bot commented Nov 16, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ring Mode Vibration Pattern Argue

1 participant