Repository navigation
feat: -V also say which optional feature are built in - #8
Open
bluzername wants to merge 1 commit into
Open
bluzername wants to merge 1 commit into
bluzername wants to merge 1 commit into
Conversation
-V/--version only print the version number, but --format webp (or jpeg, avif) can fail with "this slimdeer was built without the X feature" when that feature was off at build time (encode.rs). There was no quick way to check which feature a given binary have, short of open it or rebuild from scratch. Now -V list the optional feature too, like "slimdeer 0.3.1 (oxipng, webp, jpeg, avif, parallel)". A new test check both -V and --version give the version and all five default feature.
|
@bluzername is attempting to deploy a commit to the Adastralab AI Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
`-V`/`--version` only print the version number right now, but `--format webp` (or jpeg, avif) can fail with "this slimdeer was built without the X feature" when that feature was off at build time (`cli/encode.rs`). There was no fast way to check which feature a given binary have, other than open the binary or rebuild from source.
What change:
Small and should not touch anything else, since it is additive to what `-V` already print. I could not run `cargo test` on my side this time (no code execution in my environment this run) - please check it build and the test pass before merge, I am happy to fix anything.