Chore: deploy CommandGrid preview from main#9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deploy-previewjob to the existing CI workflow.commandgrid-previewonly after the CIcheckjob succeeds onpushtomain.workflow_dispatchpreview deploys, guarded so deploy only runs fromrefs/heads/main.Root cause
mainCI was building the Cloudflare bundle withnpm run cf:build, but no workflow step deployed the preview Worker, so preview could become stale after merges.Workflow behavior
main: run existing CI checks first, then deploy preview withnpx wrangler deploy --env preview.main.Required secrets/config
CLOUDFLARE_API_TOKENCLOUDFLARE_ACCOUNT_IDCLOUDFLARE_HYPERDRIVE_LOCAL_CONNECTION_STRING_COMMANDGRID_DBThe workflow verifies these are present by name before deploying and does not print secret values.
Verification
npm cinpm run lintnpm run typechecknpm testnpm run cf:build.github/workflows/ci.ymlparsed with PyYAML and reviewed by inspection.gh workflow view ci.yml --ref chore/cloudflare-preview-deploy-workflow --yamlcheckpassed;deploy-previewskipped on PR branch by design.Risks / notes
mainref, the deploy job is skipped by design.