Phase 6B: approval governance audit UI#8
Merged
Conversation
Contributor
Author
|
[CommandGrid][Phase 06B][PR_OPEN] Ralph: PR is open and CI is green. Please request Scout review for merge-ready verdict. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/api/approvals/:id/decide.Files changed
src/app/(app)/approvals/**src/app/(app)/audit/**src/modules/approvals/components/**src/modules/audit/components/**src/modules/governance/**src/app/(app)/incidents/[id]/page.tsxsrc/lib/navigation.tstests/governance-ui.test.tsVerification
git remote -vconfirmedhttps://github.com/hexitlabs/commandgrid.git.git fetch --prunerun; branch based onorigin/mainat Phase 6A merge0457024dd1720dd8a6f263a4a3329a0e4d46b568.npm install✅ (up to date; npm reports 8 moderate vulnerabilities, existing audit advisory state)npm run lint✅npm run typecheck✅npm test✅ (31 passed, 5 skipped)npm run build✅npm run cf:build✅npm run db:check✅ afternpm run demo:resetnpm run governance:audit-smoke✅ (unauthorized_blocked=true, continuation resumed)npm run demo:reset && npm run db:check✅ to restore demo DB after approval smoke.Visual / route review
Browser screenshots were not captured because the Clawdbot browser tool could not start:
PortInUseError: Port 18801 is already in useandssshowed the port owned byhexos-gateway. Per handoff instructions, I performed curl/API route smoke instead:GET /approvals?role=ops-manager→ 200GET /approvals?role=engineer→ 200GET /approvals?role=finance-reviewer→ 200GET /approvals?role=admin→ 200GET /approvals/approval_buffer_mode?role=ops-manager→ 200GET /audit?role=admin→ 200GET /audit?role=ops-manager&outcome=requested→ 200GET /api/approvals?role=ops-manager&status=pending&limit=5returned pendingapproval_buffer_modewithcanDecide=true./api/approvals/approval_buffer_mode/decidereturned 403.approval_buffer_mode, returned 202, continuationresumed, audit query showed approved log with actorRoleops-manager; demo reset was run afterward.Risks / notes
canDecidereturned by backend but does not replace Phase 6A permission enforcement.metadataSummaryonly; no raw metadata/log dumps exposed.Acceptance checklist
merge-ready.[CommandGrid][Phase 06B][PR_OPEN] Ralph: please request Scout review for merge-ready verdict.