Add fork-safe Android release verification and device acceptance - #109
Merged
Merged
Conversation
Default stays hermes-webui/hermes-android; release workflow pins the override to github.repository so a signed github build from a fork checks that fork's releases. Release=play and debug=none channels unchanged.
…x workflow version interpolation
|
Reviewed at exact head What holds up
Non-blocking notes (for the manual-acceptance path, not the CI path)
Scope-wise this is operator/deployment hardening of the release pipeline (configurable fork releases + signed-artifact identity verification + a device-acceptance checklist behind an explicit human approval gate), which is squarely in-scope. Nothing here needs a change to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GITHUB_RELEASES_REPOwhile preserving the upstream defaultVerification
python3 -m pytest tools/tests/test_verify_release_apk.py -q— 12 passedpython3 -m py_compile tools/verify_release_apk.py tools/tests/test_verify_release_apk.py— passed./gradlew :app:testDebugUnitTest --no-daemon— 159 tests, 0 failures/errors/skips./gradlew :app:assembleDebug --no-daemon— passedgit diff --check— passedBoundaries