Make CI checks safe to require on main - #102
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Preparation for making CI checks required on
main. GitHub reports a skippedrequired status check as pending forever, so a docs-only pull request would have
hung and never become mergeable under the previous shape.
unit-tests,android-lint, anddebug-buildno longer skip at the joblevel. They always run and always report a conclusion; on a documentation-only
change set each individual step short-circuits instead, so the checks still go
green in seconds without compiling anything.
docs-renderis now unconditional for the same reason. It scans the whole treein about four seconds, so gating it on changed paths bought nothing and made it
unsafe to require.
docs-linksstays conditional andcontinue-on-error. It depends on thenetwork and is not a merge gate.
Two contract tests enforce the shape so it cannot regress:
docs_onlyguard, and none ofthe three may skip at the job level.
always().Testing
python -m unittest discover -s tools/tests -p 'test_*.py'— 47 passed.have either no condition or
${{ always() }}, whiledocs-linksandandroid-ui-smokeremain conditional and unrequired.re-run.
Follow-up
Once this lands, the
mainruleset will require:docs-render,release-tooling-tests,webui-script-syntax,webui-script-lint,unit-tests,android-lint, anddebug-build.