Repository navigation
Add HTTP Client plugin - #117
Open
doctatortot wants to merge 3 commits into
Open
doctatortot wants to merge 3 commits into
doctatortot wants to merge 3 commits into
Conversation
hermes-plugin.json (id doctatortot.http-client, permissions network+ storage+clipboard.write — no engines/minAppVersion yet since this depends on api.network.request, which is hermes-ide#384, not yet merged/released), activate.ts, and HttpClientPanel.tsx (method/url/header rows/body form, status+headers+body response view with JSON pretty-print, copy-to- clipboard, last-20 request history via storage). NOT YET DONE: npm install, npm run build, tsc check, any actual testing against a running app. Pausing here — Doc is picking this up from another session. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
React.CSSProperties needs an explicit React import under isolatedModules; matches the `import * as React from "react"` convention used by the github and kanban-board plugins. tsc --noEmit and vite build both clean.
CONTRIBUTING.md requires a registry/index.json entry as part of the plugin PR; the initial commit missed it. minAppVersion intentionally omitted, same as the manifest — set it once hermes-ide#384 merges.
Author
|
Pushed a follow-up commit adding the registry/index.json entry — missed it in the initial commit. minAppVersion still intentionally unset pending hermes-ide#384. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
api.storage.api.network.request()call (added in Add api.network.request() for plugins needing more than GET/POST hermes-ide#384) since the existingfetch()/postJson()helpers only cover GET/POST with text-only response bodies — not enough for a general HTTP client.Note for review
hermes-plugin.jsondeliberately has noengines/minAppVersionset yet, since this plugin depends onapi.network.request()from hermes-hq/hermes-ide#384, which is open but not yet merged. Please setminAppVersiononce that PR ships (same pattern as the GitHub plugin'sminAppVersionbump forplugin_post_json).Test plan
npm installtsc --noEmitcleannpm run build(vite) clean