Repository navigation
refactor: audit batch 14 — Q03,Q07 transport/API split first slices - #216
Merged
Merged
Conversation
Completes the 2026-09-05 GPT-6 audit (ROADMAP.md): - Q03: removed the dead typed cron endpoint duplicates — the seven typed cron endpoints in HermesApi and their unused HermesRepository wrappers (getCron/createCron/pauseCron/resumeCron/triggerCron/updateCron/deleteCron) had zero callers; CronViewModel's raw path (with semantic-OK handling) is the single live contract. SyncSnapshot.cron carries the raw JsonElement and HermesSyncWorker decodes it via parseCronJobs. One endpoint per path. - Q07: extracted ChatDictationController out of ChatViewModel — server dictation session tracking (tab+generation), voice-scope guard, and the server STT capability probe/cache (TTL, per-scope one-shot probing) now live in an independently testable controller; ChatViewModel delegates. 4 regression tests in ChatDictationControllerTest. Local: 598 tests, 0 failures. Fixes: #150 (Q03), #156 (Q07)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Final block of the 2026-09-05 GPT-6 audit — Q03 + Q07, closing out all 141 findings.
Q03 — transport/API split (dead duplicate collapse)
Q07 — ChatViewModel ownership split (dictation slice)
Test plan
Fixes: #150 (Q03), #156 (Q07)
Part of the 2026-09-05 audit sweep (all 141 findings implemented across batches 1–14).