Skip to content

Preserve terminal input when PTY send is rejected - #208

Closed
mikemikimike wants to merge 1 commit into
hermes-gadget:mainfrom
mikemikimike:fix-issue130
Closed

mikemikimike wants to merge 1 commit into
hermes-gadget:mainfrom
mikemikimike:fix-issue130

Conversation

@mikemikimike

Copy link
Copy Markdown

Summary

Fixes #130 by preserving terminal input when PTY command delivery is not confirmed.

Changes

  • Use the checked PTY send result before recording or clearing input.
  • Preserve input and report whether delivery may have been partial or was not confirmed.
  • Add regression coverage for partial rejection and accepted sends.
  • Document the fix in the unreleased changelog.

Validation

  • ./gradlew :app:testDebugUnitTest --tests com.hermesgadget.talaria.feature.terminal.TerminalViewModelTest
  • ./gradlew :app:lintDebug
  • ./gradlew :app:assembleDebug

Compatibility and limitations

The full unit-test task was attempted; unrelated Robolectric baseline failures remain in the local SDK/test environment.

Fixes #130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment