Repository navigation
fix: audit batch 6 — B11,B24,B26,B27,B30,B31,B37-B40,P01,P04,P13 with regression tests - #207
Merged
Merged
Conversation
…P13 with regression tests Continues the 2026-09-05 GPT-6 audit (ROADMAP.md): - B11: activity collector arms on FIRST connection (scope-flow re-arm) and attributes rows to the snapshot captured at event arrival. - B24: dictation no longer restarts on onEndOfSpeech — the final result is delivered before the continuous loop restarts (from onResults). - B26: shared normalizeTimestampMillis unifies epoch-seconds/millis/ISO; garbage and non-finite rejected; sessionRecency + auto-open recency both use it. - B27: CronJob.schedule accepts dashboard v0.19.1 object shape via FlexibleScheduleSerializer (renders "method: expression"). - B30: PtyEvent.Connected carries the RESUMED session id instead of a fabricated UUID; share image attach targets a real session. - B31: UTF-8 prefix validation tolerates a multi-byte char split at the read boundary. - B37: prompt response only clears the prompt it answered (requestId check) — newer prompts survive. - B38: queued messages requeue at the FRONT when the transport rejects the send (ComposerQueue.requeueFront). - B39: background-tab drafts no longer wipe the active connection scope's persisted draft. - B40: freshly attached images are removable again (null==null staging check fixed). - P01: Application.onCreate disk cleanups moved off the main thread. - P04: AnsiStripper zero-alloc fast path for GROUND-state frames without escapes. - P13: Markdown link scan is linear (no per-bracket indexOf over the suffix); parsing runs on Dispatchers.Default with last-good rendering; pathological-input perf test. Regression tests: TimestampNormalizationTest, CronScheduleDecodeTest, MarkdownPathologicalInputTest. Full suite: 559 tests, 0 failures.
This was referenced Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sixth block of the 2026-09-05 audit (ROADMAP.md): 13 findings fixed with regression tests. Session/activity, dictation, cron, share, chat queue/draft/image flows, startup I/O, ANSI allocation, and Markdown CPU safety.
Findings
B11, B24, B26, B27, B30, B31, B37, B38, B39, B40, P01, P04, P13
Test plan
TimestampNormalizationTest,CronScheduleDecodeTest,MarkdownPathologicalInputTestadded.Closes the matching audit issues (audit-2026-09-05 label).