fix(agent): wait for prompt enter submission - #2461
Conversation
refs herdrdev#2422 Co-authored-by: Cursor <cursoragent@cursor.com>
|
Hi @charlieYong, thanks for your interest in contributing. Herdr does not accept unsolicited implementation pull requests from contributors who are not listed in The pull request author is not an approved contributor. If you encountered a reproducible bug, report the observed behavior through the bug issue template. A report does not reserve the work or authorize a pull request; accepted fixes are normally implemented by Herdr’s maintainer-controlled agents. Feature requests, behavior changes, and other proposals belong in GitHub Discussions. Do not open an issue merely to justify an implementation that was already written. If a maintainer explicitly wants this implementation, they can reopen the pull request. Reopening by anyone else will be closed again automatically. See https://github.com/herdrdev/herdr/blob/master/CONTRIBUTING.md for the contribution policy. |
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Summary
agent.promptcould return /--waitcould resolve while prompt text still sat unsubmitted in the composer, because delayed Enter was scheduled separately and composer text alone could advancestate_change_seq.--waitsleeps through the Enter delay, then rebaselines effect observation on a post-Enterstate_change_seqso pre-Enter screen updates cannot satisfy the effect gate. Callers without--waitstill return immediately after enqueue.refs #2422
Test plan
ordered_submission_*pane tests (interleave deferred; second hold rejected)agent_prompt_sends_text_then_delays_enterandagent_prompt_orders_enter_before_intervening_inputprompt_wait_rebaseline_rejects_composer_only_seq_bumpcargo fmt --check+cargo clippy -D warningsherdrbinary unit tests (3035)just ciin this environment: PTY-spawned integration tests (auto_detect_*, some session/client_mode/multi_client) also fail on cleanmasterhere; not caused by this patchMade with Cursor