Skip to content

attempt at review #1

Description

@altarchess

Hello @henrinikku !
As a disclaimer: I barely know any python, so giving any useful advice just seems very difficult.

What I tested

I tested 10c85a , on ubuntu 20.04 lts & python 3.10.2.

I ran
poetry install
poetry run pre-commit install --install-hooks

And then for example (tried with a number of different files)
poetry run astdiff astdiff/context.py astdiff/differ.py
And to my understanding everything worked just as it was suposed to :)
(Also tried with the exact same files, in which case it properly gave an empty edit script)

When comparing 2 empty files, it does give
Edit script (2 ops): Delete(node=Node(label='file_input', value='')) Insert(node=Node(label='file_input', value=''))
Which I found confusing

I also read https://serg.aau.at/pub/MartinPinzger/Publications/Fluri2007-changedistiller.pdf in an Attempt to understand what the code does. However, my python knowledge is just too limited to give any useful feedback.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions