Fix ProGuard/R8 crash with React Native 0.87 and AGP 9 - #976
Open
AlexCernik wants to merge 1 commit into
Open
Conversation
When using React Native 0.87 with AGP 9 and R8/ProGuard enabled, the app can crash on startup with the following error:
Wrong configuration of external resource loader:
java.lang.AssertionError:
Class net.time4j.android.spi.AndroidResourceLoader
has no zero argument constructor
This was not reproducible with React Native 0.86.2 and NDK 27.
This PR updates the ProGuard documentation with the rules required to prevent R8 from removing the zero-argument constructor used by Time4J:
`
-keep public class net.time4j.android.ApplicationStarter
-keep public class net.time4j.PrettyTime
-keep public class net.time4j.android.spi.AndroidResourceLoader {
public <init>();
}
`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using React Native 0.87 with AGP 9 and R8/ProGuard enabled, the app can crash on startup with the following error:
Wrong configuration of external resource loader:
java.lang.AssertionError:
Class net.time4j.android.spi.AndroidResourceLoader has no zero argument constructor
This was not reproducible with React Native 0.86.2 and NDK 27.
This PR updates the ProGuard documentation with the rules required to prevent R8 from removing the zero-argument constructor used by Time4J: