Repository navigation
ci: add a CI workflow, and stop biome 2.5 flagging Tailwind at-rules - #23
Merged
Merged
Conversation
Two problems. 1. No CI at all. Nothing gated merges on this repo. 2. biome.json is already out of step with the installed biome. @biomejs/biome is declared ^2.4.7, so npm ci resolves 2.5.4, which added lint/suspicious/noUnknownAtRules to recommended. That rule does not know Tailwind v3's @tailwind at-rules, so src/styles/tailwind.css produces 3 errors and npm run lint exits non-zero. Same unpinned-tooling pattern that turned three sibling repos red on ruff 0.17.0. Fix: - noUnknownAtRules: "off" in the suspicious block, consistent with how this config already handles 30+ rules - New CI workflow: npm ci -> lint -> typecheck -> test:data The unit suite is 96 percent green and is deliberately not gated: test:data reports 9710 pass / 393 fail / 6 skipped of 10109. Those 393 were already failing; this repo had no CI so nothing surfaced them, and this change does not touch application code. The step runs with continue-on-error: true so the debt stays visible. Flip it to blocking once fail == 0. Verified locally: lint pass (3 errors -> 0), typecheck pass.
hemv-857
added a commit
that referenced
this pull request
Oct 12, 2026
…visories) (#24) Runs `npm audit fix` with no --force, so only non-breaking resolutions moved. package-lock.json is the only file that changed; package.json ranges are untouched. Root npm audit: 40 -> 34 (1 critical, 19 high, 11 moderate, 3 low). Verified: lint pass, typecheck pass, test:data 9710 pass / 393 fail / 6 skipped of 10109 - identical to before the bump, so nothing regressed. The 393 failures are pre-existing and unrelated; see #23. Co-authored-by: Hemang Varshney <hemv-857@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Oct 12, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two problems
1. No CI at all. Nothing gated merges on this repo.
2. biome.json is out of step with the installed biome.
@biomejs/biomeis declared^2.4.7, sonpm ciresolves 2.5.4, which addedlint/suspicious/noUnknownAtRulesto recommended. That rule does not know Tailwind v3@tailwindat-rules, sosrc/styles/tailwind.cssproduces 3 errors andnpm run lintexits non-zero.Same unpinned-tooling pattern that turned three sibling repos red on ruff 0.17.0.
Fix
noUnknownAtRules: "off"in thesuspiciousblock, consistent with how this config already handles 30+ rulesCIworkflow:npm ci→npm run lint→npm run typecheck→npm run test:dataThe unit suite is 96% green and I did not gate on it
npm run test:datareports 9710 pass / 393 fail / 6 skipped out of 10109. Those 393 were already failing — this repo had no CI, so nothing ever surfaced them, and this change does not touch application code.Rather than add a red gate or quietly omit the suite, the test step runs with
continue-on-error: true. It stays visible and the number should only go down. Flip it to blocking oncefail == 0.Verified locally
npm run lintnpm run typechecknpm run test:data