Skip to content

feat: close research platform issues 36-38 - #56

Open
Cordis798 wants to merge 3 commits into
helsome:mainfrom
Cordis798:feat/issues-36-38-research-platform
Open

feat: close research platform issues 36-38#56
Cordis798 wants to merge 3 commits into
helsome:mainfrom
Cordis798:feat/issues-36-38-research-platform

Conversation

@Cordis798

Copy link
Copy Markdown

Summary

This PR closes #36, #37, and #38 for the research platform. Issue #39 is intentionally excluded because it is already claimed by another contributor.

Test Coverage

Focused affected suites: 196 tests passed after the final hardening changes (context, export, automation, research runner, Electron IPC, and UI context/export paths). The broader coverage audit estimated 80% overall coverage; the remaining gaps are primarily full Electron UI/E2E flows and LLM-judge evaluation paths.

Pre-Landing Review

The maintainability/testing review findings were addressed, including serialized context mutations, typed IPC parsers, shared AgentPanel retry startup, explicit context-save failures, scheduler leases/backoff, notification redaction, bounded job inputs, and unique snapshot IDs. The independent adversarial review findings were also fixed. The security-specialist pass was unavailable due to its usage limit; URL/IPC/privacy boundaries were manually reviewed and covered by tests.

Design Review

Research report export and context selection UI were reviewed with focused component tests. No unresolved design findings remain for the changed surfaces.

Eval Results

  • bun scripts/eval/run.ts --smoke --store .eval-store: 15/15 deterministic cases passed (composite score 0.757).
  • bun run e2e:issues-36-38: evidence artifacts generated with 6 live source checks, 4 exported sources, 5 instruments, 2 frozen snapshots, and success/failure background notifications.

The issues-36-38 script is a cross-package evidence harness (live URL availability plus real shared repositories/export code); it is not a full Electron IPC/UI E2E test. Production Electron E2E remains a follow-up gap.

Verification Results

  • bun run typecheck: passed for core, i18n, shared, and UI.
  • Manual Vite renderer/main builds plus preload/main bundling: passed.
  • Full bun test --isolate: 1233 passed, 7 skipped, 2 pre-existing locale-dependent failures (formatDate and TodayView currency expectation).

Plan Completion

No plan file detected.

Test plan

  • Typecheck all workspace packages
  • Focused regression and feature tests
  • Deterministic evaluation smoke suite
  • Cross-package issues-36-38 evidence harness
  • Full Electron UI/IPC E2E against a packaged app (follow-up)

Closes #36
Closes #37
Closes #38

@helsome helsome left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

测试报告本身已经比较完整,这条当前只差 UI 证据。

本 PR 修改了 AgentPanelContextChipExportMenu 等可见界面,请在 PR 描述或评论中直接贴出实际 UI 截图:

  • 至少一张修改后的 After 截图;
  • 如果是对已有界面的明显改造,优先补 Before / After;
  • 截图应能看到 context selection / export 相关最终界面状态。

仓库中的 report PNG/artifact 不能替代产品 UI 截图。补齐截图后再继续通过审核。

@Cordis798

Copy link
Copy Markdown
Author

Product UI evidence (After)

Captured from a running Folio Electron renderer after the #36/#37/#38 changes (not the repository report artifacts):

Context selection

Folio AgentPanel with watchlist and portfolio context selected

The AgentPanel visibly shows the 研究 · NVDA.US context chip and checked 使用关注列表 / 使用投资组合 selections.

Export menu

Folio research report with Export menu open

The rendered report is visible with the Export menu open, including Markdown, printable HTML, archive JSON, share copy, and SVG share-card actions.

These are product UI screenshots from the actual renderer state; the existing evaluation/report PNGs are separate test artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants