feat: add safe local skill installation - #4
Open
eric7h wants to merge 2 commits into
Open
Conversation
Owner
|
Review 结论:Request changes。\n\n[P1] 标准 YAML 多行 description 解析错误。项目中的 description: | 和 description: > 会被解析成字面量 | / >,因为当前 frontmatter parser 只解析单行标量。仓库自身的技能包(例如 skills/longbridge-content/SKILL.md)就使用了这种格式。\n\n我实际验证到:技能 description 变成 |,触发关键词数量变为 0。这样本地安装虽然能成功,但设置页和技能路由会丢失真实描述与触发词。\n\n请修复块字符串解析,或改用 YAML parser,并增加 | / > 格式的回归测试。相关代码:packages/skill-hub/src/index.ts:491-545。 |
eric7h
force-pushed
the
feat/local-skill-install
branch
from
September 3, 2026 01:49
394c1be to
d10ea21
Compare
helsome
reviewed
Sep 11, 2026
helsome
left a comment
Owner
There was a problem hiding this comment.
补充当前 UI 验收要求:这条涉及 Settings → Skills 的可见界面。你修完现有 YAML block string blocker 后,请在 PR 中补至少一张实际修改后的 Skills UI 截图;如果相对原界面有明显变化,优先 Before/After。现有测试报告可以继续沿用,不需要额外扩大测试范围。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
~/.finagent/skillsand move removals to TrashValidation
bun run typecheckbun run i18n:checkbun run buildgit diff --checkFull-suite baseline note:
origin/main: 811 passed, 337 failedThe existing failures reproduce on
origin/mainand begin with missing Longbridge fixture files; this change adds no new failures.