Skip to content

fix(eval): restore main typecheck after #116 - #142

Merged
helsome merged 1 commit into
mainfrom
hotfix/main-runtime-unusable
Sep 20, 2026
Merged

helsome merged 1 commit into
mainfrom
hotfix/main-runtime-unusable

Conversation

@helsome

@helsome helsome commented Sep 20, 2026

Copy link
Copy Markdown
Owner

目的

只修复当前 main#116 合并后出现的 TypeScript 集成回归,不包含 #122 的其他功能改动。

当前 main:ff3ed3d031568a892f115c6e1cb70899d4e593c2

main workflow 35340976577

  • Full unit tests: success
  • Secret scan: success
  • Typecheck: failure
  • 准确错误:packages/shared/src/evaluation/experiment-service.ts(534,7) TS2741,配置应用失败的早退返回缺少 runtimeUnusable

修复

CONFIG_APPLY_FAILED 分支从:

return { run: failedRun, aborted: false };

改为:

return { run: failedRun, aborted: false, runtimeUnusable: false };

此时 Agent run 尚未启动;配置未能应用属于 case 未开始执行,不应把 runtime 标记为 unusable。

验证

维护者 GitHub Actions 将作为本 PR 的实际验证来源。目标是恢复:

  • Typecheck
  • Focused tests
  • Full unit tests (advisory)
  • Secret scan

这是单行内部类型/语义修复,无可见 UI 变化。

helsome commented Sep 20, 2026

Copy link
Copy Markdown
Owner Author

维护者验证报告(GitHub Actions run 35496872567,PR merge ref c3431c5ebb3e1bb998d5b977c8b4676c97d578e8

环境:

  • GitHub-hosted ubuntu-latest
  • Bun 1.4.2+744846f84

实际执行及结果:

  • bun run typecheck:core / i18n / shared / ui / electron 全部 exit 0。
  • Focused tests(workflow 按 changed workspace 执行 bun test packages/shared --isolate):995 pass / 0 fail / 3938 assertions
  • bun test --isolate1513 pass / 7 skip / 0 fail / 6786 assertions
  • Secret scan:No secret patterns found.

对照:current main ff3ed3d031568a892f115c6e1cb70899d4e593c2 的 workflow 35340976577 在同一 bun run typecheck 上稳定报 experiment-service.ts(534,7) TS2741,而本 hotfix merge ref 已恢复全 workspace typecheck。

验证等级:FIXTURE/CI;本修复不涉及真实模型、Provider 或 UI。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant