Conversation
helsome
reviewed
Sep 20, 2026
helsome
left a comment
Owner
There was a problem hiding this comment.
这份实现与已开放且已 APPROVE 的 #121 是同一修复,生产 diff 也等价:都是保留逗号分隔空列、parts[0] ?? '',并覆盖同一组 parse/draft/persist/reload 回归。#121 现在已经 clean rebase 到当前 main、GitHub 显示 mergeable=true,并且已有更完整的 Bun 1.4.2 / Windows 11 可复现报告;同时它早于本次 /claim 存在。因此不保留两份竞争实现,选择已有批准且验证材料更完整的 #121 作为落地 PR。本 PR 关闭为 superseded/duplicate,不代表实现方向有问题,也不要求你继续维护第二份相同改动。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
变更说明
修复粘贴导入中逗号分隔空单元格被过滤、导致数量/成本/币种按压缩后的索引读取的问题。
symbol,cost两列简写语义。Closes #120
验证结果
bun test packages/shared/src/portfolio-import:78 pass / 0 failbun test packages/shared --isolate:1003 pass / 0 failgit diff --check:通过src/evaluation/experiment-service.ts:534阻塞:返回值缺少runtimeUnusable;与本 PR 无关。