Skip to content

LCM: Upgrade Node, typescript, bundler and linter#37

Open
petter-a wants to merge 7 commits into
mainfrom
dev
Open

LCM: Upgrade Node, typescript, bundler and linter#37
petter-a wants to merge 7 commits into
mainfrom
dev

Conversation

@petter-a

Copy link
Copy Markdown
Contributor

This pull request makes a major shift in the project's frontend tooling and build system. It migrates the project from Yarn, ESLint, and Prettier to npm, Vite, and Biome, updates Node.js to version 22, and removes legacy configuration files. The changes also update dependencies, scripts, and documentation to reflect the new stack.

Build system and tooling migration:

  • Migrated from Yarn to npm for dependency management, including removing Yarn-specific commands and cache steps from GitHub Actions and Dockerfiles, and updating documentation accordingly. (.github/workflows/automatic-tests.yml, Dockerfile, Dockerfile.local, README.md, [1] [2] [3] [4] [5]
  • Replaced Create React App (CRA) with Vite for building and serving the frontend, updating scripts in package.json and removing CRA-specific files and references. (package.json, public/index.html, index.html, [1] [2] [3]

Linting and formatting:

  • Removed ESLint and Prettier configuration and dependencies, and replaced them with Biome for linting and formatting, including adding a biome.json config and updating VSCode extension recommendations. (.eslintrc.js, .prettierrc.js, package.json, biome.json, .vscode/extensions.json, [1] [2] [3] [4] [5]

Node.js and dependency updates:

  • Updated Node.js version requirement to 22 across the project, including Docker images, .nvmrc, and package.json engines. (Dockerfile, Dockerfile.local, .nvmrc, package.json, [1] [2] [3] [4]
  • Updated several dependencies and devDependencies to be compatible with the new toolchain, including @yudiel/react-qr-scanner, @types/node, and others. (package.json, [1] [2]

Codebase cleanup and minor fixes:

  • Updated import statements for type-only imports to use type keyword for better compatibility and clarity. (src/App.tsx, src/admin/AdminButton.tsx, src/admin/AdminView.tsx, [1] [2] [3]
  • Fixed missing dependencies in React hooks and improved code consistency. (src/App.tsx, src/App.tsxL94-R93)

These changes modernize the project's frontend workflow, improve performance and developer experience, and simplify configuration management.

petter-a and others added 7 commits May 19, 2026 11:36
* upgrade node version

* fix(ci): use Node.js 22 in automatic test workflow

Agent-Logs-Url: https://github.com/helsingborg-stad/haffa-web/sessions/4231600d-4da7-43b2-a402-96049f266917

Co-authored-by: petter-a <40427478+petter-a@users.noreply.github.com>

---------

Co-authored-by: Petter Andersson <petter.andersson@helsingborg.se>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
* initial commit

* test(string-utils): cover isValidColorOr fallback behavior

Agent-Logs-Url: https://github.com/helsingborg-stad/haffa-web/sessions/9320f365-06cc-4b49-83c2-1dd1adf8d749

Co-authored-by: petter-a <40427478+petter-a@users.noreply.github.com>

---------

Co-authored-by: Petter Andersson <petter.andersson@helsingborg.se>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
* initial commit

* chore(pr): finalize review comment analysis

Agent-Logs-Url: https://github.com/helsingborg-stad/haffa-web/sessions/d55c24ae-3a8f-40db-afde-806d893ea7a0

Co-authored-by: petter-a <40427478+petter-a@users.noreply.github.com>

* chore(pr): remove unintended lockfile changes

Agent-Logs-Url: https://github.com/helsingborg-stad/haffa-web/sessions/d55c24ae-3a8f-40db-afde-806d893ea7a0

Co-authored-by: petter-a <40427478+petter-a@users.noreply.github.com>

* fix(vite): avoid loading all env vars in config

Agent-Logs-Url: https://github.com/helsingborg-stad/haffa-web/sessions/a94739ed-eb0f-4fa8-ad58-b4b8d052853a

Co-authored-by: petter-a <40427478+petter-a@users.noreply.github.com>

---------

Co-authored-by: Petter Andersson <petter.andersson@helsingborg.se>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
* initial commit

* fix: move index.html to root as required by vite

---------

Co-authored-by: Petter Andersson <petter.andersson@helsingborg.se>
* change yarn to npm

* fix npm bug

* fix npm bug

* fix npm bug

---------

Co-authored-by: Petter Andersson <petter.andersson@helsingborg.se>
Co-authored-by: Petter Andersson <petter.andersson@helsingborg.se>
@petter-a petter-a requested a review from jlarsson May 29, 2026 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant