Skip to content

refactor: components use php config files#619

Draft
NiclasNorin wants to merge 1 commit into
mainfrom
refactor/components-use-php-config-files
Draft

refactor: components use php config files#619
NiclasNorin wants to merge 1 commit into
mainfrom
refactor/components-use-php-config-files

Conversation

@NiclasNorin

Copy link
Copy Markdown
Contributor

No description provided.

@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Feb 26, 2026

Copy link
Copy Markdown

CI Feedback 🧐

(Feedback updated until commit 3de706a)

A test triggered by this PR failed. Here is an AI-generated analysis of the failure:

Action: Test running PHP 8.0

Failed stage: Install dependencies [❌]

Failed test name: ""

Failure summary:

The action failed during the composer install --prefer-dist --no-progress step because Composer hit
a PHP parse error while loading an installed Composer plugin.
- Error: [ParseError] syntax error,
unexpected token ")"
- Location: MagoPlugin.php line 92
This prevented Composer from
initializing/loading plugins (Composer\Plugin\PluginManager->loadInstalledPlugins()), so dependency
installation aborted and the job exited with code 1.

Relevant error logs:
1:  ##[group]Runner Image Provisioner
2:  Hosted Compute Agent
...

498:  Cache hit for: Linux-php-52f596f4e36ad887755f7c6be448b122b6458bd5504e4deaaec5d93e8657bb5d
499:  Received 16777216 of 40131129 (41.8%), 16.0 MBs/sec
500:  Received 40131129 of 40131129 (100.0%), 32.6 MBs/sec
501:  Cache Size: ~38 MB (40131129 B)
502:  [command]/usr/bin/tar -xf /home/runner/work/_temp/638e953a-fd34-4928-b064-bdcf23310a19/cache.tzst -P -C /home/runner/work/component-library/component-library --use-compress-program unzstd
503:  Cache restored successfully
504:  Cache restored from key: Linux-php-52f596f4e36ad887755f7c6be448b122b6458bd5504e4deaaec5d93e8657bb5d
505:  ##[group]Run composer install --prefer-dist --no-progress
506:  �[36;1mcomposer install --prefer-dist --no-progress�[0m
507:  shell: /usr/bin/bash -e {0}
508:  env:
509:  COMPOSER_PROCESS_TIMEOUT: 0
510:  COMPOSER_NO_INTERACTION: 1
511:  COMPOSER_NO_AUDIT: 1
512:  ##[endgroup]
513:  ##[error]syntax error, unexpected token ")"
514:  In MagoPlugin.php line 92:
515:  [ParseError]                        
516:  syntax error, unexpected token ")"  
517:  Exception trace:
...

523:  Composer\Plugin\PluginManager->loadRepository() at phar:///usr/local/bin/composer/src/Composer/Plugin/PluginManager.php:103
524:  Composer\Plugin\PluginManager->loadInstalledPlugins() at phar:///usr/local/bin/composer/src/Composer/Factory.php:448
525:  Composer\Factory->createComposer() at phar:///usr/local/bin/composer/src/Composer/Factory.php:627
526:  Composer\Factory::create() at phar:///usr/local/bin/composer/src/Composer/Console/Application.php:578
527:  Composer\Console\Application->getComposer() at phar:///usr/local/bin/composer/src/Composer/Command/BaseCommand.php:128
528:  Composer\Command\BaseCommand->tryComposer() at phar:///usr/local/bin/composer/src/Composer/Command/BaseCommand.php:239
529:  Composer\Command\BaseCommand->initialize() at phar:///usr/local/bin/composer/vendor/symfony/console/Command/Command.php:264
530:  Symfony\Component\Console\Command\Command->run() at phar:///usr/local/bin/composer/vendor/symfony/console/Application.php:1040
531:  Symfony\Component\Console\Application->doRunCommand() at phar:///usr/local/bin/composer/vendor/symfony/console/Application.php:301
532:  Symfony\Component\Console\Application->doRun() at phar:///usr/local/bin/composer/src/Composer/Console/Application.php:420
533:  Composer\Console\Application->doRun() at phar:///usr/local/bin/composer/vendor/symfony/console/Application.php:171
534:  Symfony\Component\Console\Application->run() at phar:///usr/local/bin/composer/src/Composer/Console/Application.php:138
535:  Composer\Console\Application->run() at phar:///usr/local/bin/composer/bin/composer:112
536:  require() at /usr/local/bin/composer:29
537:  install [--prefer-source] [--prefer-dist] [--prefer-install PREFER-INSTALL] [--dry-run] [--download-only] [--dev] [--no-suggest] [--no-dev] [--no-security-blocking] [--no-autoloader] [--no-progress] [--no-install] [--audit] [--audit-format AUDIT-FORMAT] [-v|vv|vvv|--verbose] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--apcu-autoloader-prefix APCU-AUTOLOADER-PREFIX] [--ignore-platform-req IGNORE-PLATFORM-REQ] [--ignore-platform-reqs] [--] [<packages>...]
538:  ##[error]Process completed with exit code 1.
539:  Post job cleanup.

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
35.0% Duplication on New Code (required ≤ 3%)
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@sebastianthulin

Copy link
Copy Markdown
Member

@copilot Do the following tasks:

  • Replace all variable names to more appropriate names (eg. where json is mentioned, but not are anymore, change the name).
  • Create a common interface for the component, with clearly named getters (like: name, slig, identifier etc).
  • Return singleton class instance for each component configuration.
  • Input parameters on the components shoud be handled with a setter.
  • All data should be strictly typed.

Test before and after change.

Copilot AI commented Feb 26, 2026

Copy link
Copy Markdown
Contributor

@sebastianthulin I've opened a new pull request, #620, to work on those changes. Once the pull request is ready, I'll request review from you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants