Feat/document processing queue#290
Merged
Merged
Conversation
…separate thread refactor files+urls into "document" and run chunking+vectorization in a separate thread in order to not block "main" thread. BREAKING CHANGE: endpoint for updating collection content now returns immediately. Status for each document will have to be queried using GET /api/collections. Structure for files/urls have changed into documents.
instead of generated tmp name
…ork with new structure
zilaei
requested changes
Oct 6, 2025
zilaei
left a comment
zilaei
left a comment
Member
There was a problem hiding this comment.
I have added a test test_LocalFileDocumentQueueService.py for demonstrating document processing error. I'm not sure if these errors ever will trigger but added the test so that you can look and judge if it's a concern.
Main concern is: Processing fails for any reaqson -> finally tries to remove file -> file locked -> error raised -> Files still in queue.
File look is the main concern but not this might be very unlikely to happen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed file processing for assistants (RAG - chunking + vectorization) to be processed in a separate thread (started/stopped together with the backend process).