Repository navigation
Groundwork: final module paths - #165
Merged
Merged
Conversation
… status The exchange with the extension unit (short and framed writes, answer polling, the sequence counter) moves to family/exchange.rs; the Tiny 2 Lite reads and writes stay as models/tiny2lite/camera.rs; the 0.13 status shape, its capability list and the remembered pose move to legacy, with state.rs. Every block is copied unchanged by scripts/groundwork/split-camera.py (anchors matched the file on rebuild as it is); items another file now uses become pub(crate). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Every use line and the two module paths in code name the modules where they live now; lib.rs declares only the final modules. No behaviour change. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #163
Stacked on #164 (branch
fix/162-groundwork-camera-split); the diff of this pull request on top of that branch is one commit. Base staysrebuild.Task 7 of the groundwork plan. During the parallel moves the old module paths stayed valid through re-exports in
lib.rs. This change switches everyuseline and the two module paths in code to the final modules, updates two doc references, and removes the re-exports (state,frame,streaming,commands,presets,statusand thedeviceshim).lib.rsnow declares onlyenumeration,error,family,legacy,models,registryandtransport. Pure move: no change to bytes sent to the camera, ioctls, timing or command-line output. No CHANGELOG line (nothing a user can see).Verified (against the base
e7c15de):grep -rnE '(crate|obsbot_device)::(camera|commands|device|frame|presets|state|status|streaming)\b' cratesprints nothing.cargo fmt --check,cargo clippy --workspace --all-targets --locked -- -D warnings, shellcheck onscripts/groundwork/*.shandscripts/package-contents.sh, and actionlint: no output.cargo test --workspace --locked: 118, 1, 25, 2 and 0 tests passed, no failures (byte guard and CLI surface included, fixtures unedited).scripts/groundwork/test-names.shfor base and head:comm -3prints nothing (146 names, same list).cargo build --release --locked, thenobsbot4linux --versionprintsobsbot4linux 0.13.2.scripts/groundwork/move-check.sh <base> HEADprints exactly the 11 lines the plan lists (two doc references, the removed shim comment,device::detectandstate::pathcall sites,pub mod device {and its closing brace).git diff -M --stat: 11 files changed, 21 insertions, 32 deletions; no renames needed.--version.🤖 Generated with Claude Code