Repository navigation
CI: check the QML on every pull request - #133
Merged
Merged
Conversation
New .github/workflows/ci.yml, triggered only by pull requests into main (no paths filter, no push, no dispatch), contents: read. Job qml installs qt6-declarative in an Arch Linux container pinned by digest and runs scripts/check-qml.sh; Ubuntu 24.04's own Qt 6.4 qmllint does not accept the script's options. Job shellcheck checks scripts/*.sh in the same container. Job required always runs and passes only when both gates succeeded; it is the check the main ruleset will require. renovate.json extends helpers:pinGitHubActionDigests, so actions and the container image stay pinned to digests. Fixes #132 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #132
What changed
.github/workflows/ci.yml, onpull_requestintomainonly: nopaths:filter, nopush, noworkflow_dispatch, top-levelpermissions: contents: read.qml: Arch Linux container pinned by digest,pacman -Syu qt6-declarative, thenscripts/check-qml.sh. Ubuntu 24.04's own Qt 6.4.2qmllintrefuses the script's options (W,unresolved-type,missing-property,id-shadows-member,incompatible-type); Arch ships the Qt the desktop shell runs. The digest pins the image, not Qt.shellcheck: same container,shellcheck scripts/*.sh.required:if: always(),needs: [qml, shellcheck], passes only on success/success. The main ruleset will require this context.renovate.json:helpers:pinGitHubActionDigestsadded.renovate-config-validator --strict(renovate 42): "Config validated successfully".Verified locally:
actionlintclean. The proof is this pull request's own run.🤖 Generated with Claude Code