forked from ching-kuo/claude-codex
-
Notifications
You must be signed in to change notification settings - Fork 0
README install fixes harvested from upstream + plan-codex command hardening #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hellosurbhi
wants to merge
15
commits into
main
Choose a base branch
from
docs/readme-install-fixes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
4c45a7b
docs(plan-codex): mandatory mid-call failure handling for dead audits
hellosurbhi a139617
feat(plan-codex): single audit pass, re-audit only on BLOCKED
hellosurbhi fb80cfa
feat(skills): re-review only on BLOCKED across all review loops
hellosurbhi 6210261
fix(skills): round-1 review findings on the WARNING path
hellosurbhi b9da863
fix(commands,evals): align compatibility entrypoints and evals with B…
hellosurbhi 480dca1
Merge pull request #1 from hellosurbhi/skill/blocked-only-iteration
hellosurbhi f3d407b
chore(backlog): file HIGH/MEDIUM findings from the PR #1 round-2 review
hellosurbhi 658dbee
fix(skills): close the three HIGH findings from the backlog-push reviews
hellosurbhi 48f71fc
Merge pull request #2 from hellosurbhi/chore/backlog-20260803
hellosurbhi 68de8b7
chore(backlog): file MEDIUMs auto-routed by the final skills-push review
hellosurbhi 181aa8b
docs(readme): install-instruction fixes harvested from upstream PR #1
hellosurbhi 2460d27
fix(plan-codex-command): verdict grammar wired, dead prompt path repl…
hellosurbhi 9f8e9f9
fix(plan-codex-command): line-anchored verdict validation, APPROVED f…
hellosurbhi 29fad2c
fix(review-loops): fail closed at the cap, critical-evaluation gate i…
hellosurbhi cfd3f91
fix: auto-resolve PR #4 review findings
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,3 +21,4 @@ src/ | |
| package.json | ||
| package-lock.json | ||
| node_modules/ | ||
| reviews/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| ## Medium priority (auto-fix pending) | ||
|
|
||
| ### Codex (2026-08-03T04:15Z) | ||
| - [ ] MEDIUM: 1. The execute and TDD eval suites contain no WARNING-path cases. `skills/claude-codex/evals/evals.json:29` also covers remaining MEDIUM/LOW findings only after APPROVED. 2. `README.md:35-36` says Claude fixes all findings while users decide MEDIUM/LOW findings. `README.md:127` calls WARNING outcomes approved. 3. Changed Markdown retains prohibited em dashes and Oxford commas, contrary to the repository copy mandate. | ||
|
|
||
|
|
||
| ## High priority (from push reviews, fix first) | ||
|
|
||
| ### Codex (2026-08-03T04:51Z) | ||
| - [ ] HIGH: `commands/plan-codex.md:50-53` validates the verdict line but not its consistency with severity findings. `VERDICT: APPROVED` accompanied by `CRITICAL:` or `HIGH:` still reaches Phase 3 and silently drops those findings. Treat contradictory severity and verdict combinations as malformed. | ||
| - [ ] MEDIUM: `commands/plan-codex.md:48-55` does not specify whether a malformed retry uses the saved thread or starts a new one. A new call can return a replacement `threadId`, yet later re-audits may use the original thread. | ||
| - [ ] MEDIUM: `commands/plan-codex.md:50` adds the Oxford comma in “no verdict line, multiple verdict lines, or a value,” violating the repository copy mandate. | ||
|
|
||
| ### Codex (2026-08-03T05:50Z) | ||
| - [ ] HIGH: `skills/plan-codex/SKILL.md:51,61,76-87`: The CLI fallback provides no MCP `threadId`. A BLOCKED result or contested finding therefore reaches `mcp__codex__codex-reply` with no valid saved thread. Define a CLI follow-up path for the full audit loop. | ||
| - `commands/plan-codex.md:50-54`: Verdict validation ignores severity consistency. `VERDICT: APPROVED` with CRITICAL or HIGH findings still reaches Phase 3 and drops them. | ||
| - `commands/claude-codex.md:82,91-93` and `commands/plan-codex.md:51,54`: The new gate says rejected findings are not accepted, but later instructions require fixing every CRITICAL and HIGH finding. This defeats the gate on BLOCKED reviews. | ||
| - `SCOPE-CREEP`: `commands/claude-codex.md:82` expands the counterpart’s CRITICAL/HIGH evaluation gate to “ANY finding.” This can discard MEDIUM/LOW findings before the user decision in Step R3 without support in the stated intent. | ||
| - [ ] MEDIUM: `commands/plan-codex.md:48-58`: The malformed-response retry does not specify whether it reuses the thread or replaces the saved `threadId`. | ||
| - `UNASKED-CHANGE`: More than 2,000 lines of derived state under `reviews/.cache`, `reviews/.routed` and `reviews/.verdicts` were committed without a trace to the stated intent. No repository code references these artifacts. | ||
| - `ENHANCEMENTS.md:5,8`: Both new entries are stale. Current `BUGS.md:12` is a heading, while current `commands/plan-codex.md:40` already says the old analyzer exists. | ||
| - Changed Markdown introduces prohibited em dashes and Oxford commas, including `commands/claude-codex.md:82,87`, `commands/plan-codex.md:51` and `skills/plan-codex/SKILL.md:51`. | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
|
|
||
| ## Low-priority enhancements | ||
|
|
||
| ### Codex (2026-08-03T04:15Z) | ||
| - LOW: `BUGS.md:12` adds a trailing blank line flagged by `git diff --check`. | ||
|
|
||
| ### Codex (2026-08-03T04:31Z) | ||
| - LOW: `commands/plan-codex.md:40` falsely says the old analyzer path does not exist. `prompts/codex/analyzer.md` is tracked, `README.md:84` installs it and the reviewed local symlink resolves it. | ||
|
|
||
| ### Codex (2026-08-03T05:50Z) | ||
| - LOW: The range fails `git diff --check`: `ENHANCEMENTS.md:9` adds a blank line at EOF and the committed review-cache diffs contain extensive trailing whitespace. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.