Fix for "No Dispatches appearing" bug. #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding From_Timestamp to NewsFeed task
Adding NewsFeedFromTimestamp
added NewsFeedFromTimestamp into ArrowHeadApiService, this prevents a crash.
raginmari
reviewed
Jul 25, 2025
raginmari
left a comment
raginmari
left a comment
There was a problem hiding this comment.
Thanks for taking care of this. I have a few remarks.
dealloc
requested changes
Jul 26, 2025
Member
dealloc
left a comment
dealloc
left a comment
There was a problem hiding this comment.
some whitespace changes, but the bigger one is the NewsFeedFromTimestamp flag itself.
Is there any reason we're not just passing in 0 (which from rudimentary testing seems to work).
And if we'd just pass in 0, I would remove the flag itself entirely
src/Helldivers-2-Sync/Configuration/HelldiversSyncConfiguration.cs
Outdated
Show resolved
Hide resolved
src/Helldivers-2-Sync/Configuration/HelldiversSyncConfiguration.cs
Outdated
Show resolved
Hide resolved
…al issue. ${} isn't to be used in C#!
dealloc
requested changes
Jul 26, 2025
Member
dealloc
left a comment
dealloc
left a comment
There was a problem hiding this comment.
looks good, minor style changes and we're good to go on this one
Co-authored-by: Wannes Gennar <dealloc@users.noreply.github.com>
dealloc
approved these changes
Jul 28, 2025
Member
|
rolling out in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #145 (comment).
The Raw Arrowhead API has a chance of crashing if fromTimestamp isn't included in the request.
This Pull Request fixes that.