Repository navigation
report: put SVG rendering behind a default svg-reports feature - #176
Merged
statusfailed merged 1 commit intoSep 4, 2026
Merged
Conversation
`open-hypergraphs-dot` pulls in a graphviz/SVG renderer that only the diagnostic report dump uses; embedders that never ask for SVGs still compiled and linked it. Enabled by default, so existing builds are unchanged. Without the feature, `ReportOptions::generate_svgs` does not exist, so a build without the renderer cannot ask for SVGs.
georgewhewell
force-pushed
the
grw/svg-reports-feature
branch
from
September 3, 2026 11:23
a28d8ce to
a2cf11e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
open-hypergraphs-dotpulls in a graphviz/SVG renderer that only the diagnostic report dump uses; embedders that never ask for SVGs still compiled and linked it.This puts it behind an
svg-reportsfeature, enabled by default, so existing builds are unchanged. Without the feature,ReportOptions::generate_svgsdoes not exist, so a build without the renderer cannot ask for SVGs — the check is at compile time, no runtime error path.Checked:
cargo check --all-targetswith default features and with--no-default-features(the dot crate drops out of the dependency graph),cargo fmt --check.