catena-gpu naive matmul - #174
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Naive matmul for
catena-gpu. See doc for details.Change to
catena-langruntimeWe want to use the same runtime as
catena-langbecause it is currently used in other parts of the stack. We needed to change it.It was primarily an API extension, but I did touch the implementation of an existing method.
Added APIs:
GeneratedFunctionABI metadata.Runtime::dialect().Runtime::load_generated_source(source, functions).I added new method
Runtime::load_generated_source(source, functions)Existing load methods accept Hex/Catena source and always run the complete catena-lang pipeline:
That cannot load catena-gpu output. By the time catena-gpu calls the runtime, it already has generated CUDA/HIP and ABI signatures.
Runtime::load_generated_source(source, functions)adds some code duplication, but it is the safest path that does not require to change/break existing code.Questions
Hardware-dependent constraints include:
should we provide safety or is it fine if it crashes?