Skip to content

fix: align versioning in assembly with package version #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sarahsa merged 2 commits into from
Aug 19, 2026
Merged

fix: align versioning in assembly with package version #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e0e185
fix: set assembly version to the same as the package version
sarahsa Aug 18, 2026
360a9b6
explicitly set version to 0.0.0 as default for python solution
sarahsa Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions .github/workflows/nuget-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,18 +32,22 @@ jobs:
exit 1
fi

- name: Set version from tag
run: |
VERSION=${GITHUB_REF_NAME#v}
echo "Building and packing with version: $VERSION"
echo "VERSION=$VERSION" >> "$GITHUB_ENV"

- name: Restore dependencies
run: dotnet restore

- name: Build
run: dotnet build --configuration Release --no-restore
run: dotnet build --configuration Release --no-restore -p:Version=$VERSION

- name: Pack using tag version
run: |
VERSION=${GITHUB_REF_NAME#v}
echo "Packing with version: $VERSION"
dotnet pack HeimdallPower.Api.Client/HeimdallPower.Api.Client/HeimdallPower.Api.Client.csproj --configuration Release --no-build -o out /p:PackageVersion=$VERSION
dotnet pack HeimdallPower.Api.Client/HeimdallPower.Api.Client.Extensions/HeimdallPower.Api.Client.Extensions.csproj --configuration Release --no-build -o out /p:PackageVersion=$VERSION
dotnet pack HeimdallPower.Api.Client/HeimdallPower.Api.Client/HeimdallPower.Api.Client.csproj --configuration Release --no-build -o out -p:Version=$VERSION
dotnet pack HeimdallPower.Api.Client/HeimdallPower.Api.Client.Extensions/HeimdallPower.Api.Client.Extensions.csproj --configuration Release --no-build -o out -p:Version=$VERSION

- name: NuGet login (OIDC -> short-lived API key)
uses: NuGet/login@v1
Expand All @@ -56,4 +60,4 @@ jobs:
for file in out/*.nupkg; do
echo "Publishing $file"
dotnet nuget push "$file" --api-key "${{ steps.login.outputs.NUGET_API_KEY }}" -s https://api.nuget.org/v3/index.json --skip-duplicate
done
done
4 changes: 2 additions & 2 deletions python/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[project]
name = "heimdallpower-api-client"
version = "0.1.0"
version = "0.0.0"
description = "Python SDK for interacting with the Heimdall Power External API"
readme = "README.md"
authors = [
Expand Down Expand Up @@ -54,4 +54,4 @@ build-backend = "poetry.core.masonry.api"
markers = [
"integration: marks tests as integration (use with '-m integration')"
]
testpaths = ["tests"]
testpaths = ["tests"]
Loading