Refactor for type hints and clarity#4
Merged
Conversation
jpelay
approved these changes
May 12, 2026
jpelay
left a comment
jpelay
left a comment
Member
There was a problem hiding this comment.
Love the pull request! Thank you so much for applying these improvements
| return any(c in self.commands for c in cmds) | ||
|
|
||
|
|
||
| class ParseResult(NamedTuple): |
Member
There was a problem hiding this comment.
Much cleaner than using the NamedTuple directly, I like it.
jpelay
approved these changes
May 12, 2026
Contributor
Author
|
@jpelay thanks! In the future, can I request that my PR's be merged using "Rebase and Merge", particularly when I've made the point to organize a series of linear, atomic, commits? |
Kache
added a commit
to Kache/hedylang
that referenced
this pull request
Jun 7, 2026
This reverts commit 2c4f686.
Kache
added a commit
to Kache/hedylang
that referenced
this pull request
Jun 10, 2026
- **Remove dead code** - **Improve type hinting** - **Log formatted AST** - **Use AstInfo** - **Construct ConvertToPython using AstInfo** Ahead of upcoming changes for: * hedyorg#2 * hedyorg/hedy#5836 (comment)
Kache
added a commit
to Kache/hedylang
that referenced
this pull request
Jun 10, 2026
- **Remove dead code** - **Improve type hinting** - **Log formatted AST** - **Use AstInfo** - **Construct ConvertToPython using AstInfo** Ahead of upcoming changes for: * hedyorg#2 * hedyorg/hedy#5836 (comment)
Kache
added a commit
to Kache/hedylang
that referenced
this pull request
Jun 12, 2026
In order to reapply as individual atomic commits This reverts commit 2c4f686.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ahead of upcoming changes for: