Skip to content

Bump golang.org/x/sys from 0.0.0-20190529164535-6a60838ec259 to 0.1.0#19

Open
dependabot[bot] wants to merge 1 commit into
masterfrom
dependabot/go_modules/golang.org/x/sys-0.1.0
Open

Bump golang.org/x/sys from 0.0.0-20190529164535-6a60838ec259 to 0.1.0#19
dependabot[bot] wants to merge 1 commit into
masterfrom
dependabot/go_modules/golang.org/x/sys-0.1.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Feb 25, 2023

Copy link
Copy Markdown

Bumps golang.org/x/sys from 0.0.0-20190529164535-6a60838ec259 to 0.1.0.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.0.0-20190529164535-6a60838ec259 to 0.1.0.
- [Release notes](https://github.com/golang/sys/releases)
- [Commits](https://github.com/golang/sys/commits/v0.1.0)

---
updated-dependencies:
- dependency-name: golang.org/x/sys
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added the dependencies Pull requests that update a dependency file label Feb 25, 2023
gh-worker-dd-mergequeue-cf854d Bot pushed a commit to DataDog/datadog-agent that referenced this pull request Apr 30, 2026
## Summary

Replaces the direct dependency on `github.com/hectane/go-acl` (`v0.0.0-20230225031251-cdfc9e3acf94`, which is the head of upstream's unmerged [PR #19](hectane/go-acl#19)) with `github.com/DataDog/go-acl v1.0.0`, a tagged release of a DataDog-owned fork containing the same code.

## Why

Upstream `hectane/go-acl` is effectively inactive (last commit early 2023) and has no semver tags. The commit we currently pin lives on an unmerged PR branch, which made it fragile in two ways:

1. **Renovate digest updates produced malformed `go.mod` entries and time-regressing "updates"** — see #49574, where Renovate proposed bumping the dep from a Feb 2023 commit to a Jan 2023 one (older).
2. **The pinned commit could vanish** if upstream force-pushed or deleted the PR branch.

Owning a tagged fork lets Renovate resolve real semver versions and guarantees the source we depend on is immutable.

The companion guardrail PR #49861 disables digest updates for the `gomod` Renovate manager — together they prevent this class of issue across all tag-less Go deps.

## What's in the fork

[`DataDog/go-acl@v1.0.0`](https://github.com/DataDog/go-acl/releases/tag/v1.0.0) is upstream master HEAD (`ca0b05c`) plus the `golang.org/x/sys 0.1.0` bump from upstream PR #19 (cherry-picked, dependabot authorship preserved), with the `module` directive set to `github.com/DataDog/go-acl`.

## Scope

- 2 Go imports rewritten:
  - `pkg/util/filesystem/permission_windows.go`
  - `pkg/security/probe/probe_auditing_windows_test.go`
- `go.mod` and `go.sum` updates across the workspace via `dda inv tidy`.
- Bazel manifest updates (`deps/go.MODULE.bazel`, `pkg/util/filesystem/BUILD.bazel`).
- `LICENSE-3rdparty.csv` regenerated.

## About the remaining `hectane/go-acl // indirect` entries

After this PR, `hectane/go-acl` still appears as `// indirect` in some submodule `go.mod` files. Those come from `opentelemetry-collector-contrib` packages that pin older `datadog-agent` submodule versions which still required hectane. They will disappear automatically once OTel bumps its `datadog-agent` pin past this PR — no action needed on our side.

The pseudo-version on those indirect entries (`v0.0.0-20230122075934-ca0b05cb1adb`) is the upstream master HEAD as resolved by Go's MVS — the previous Feb 2023 pin (`cdfc9e3`) was a manual reference to the unmerged PR branch and was never present in the published versions of our submodules.

## Test plan

- [ ] CI builds pass (Linux + Windows).
- [ ] Go imports + build tags resolve correctly.
- [ ] `dda inv tidy` is idempotent.
- [ ] Bazel build of `pkg/util/filesystem` succeeds on Windows.
- [ ] `dda inv lint-licenses` passes.

Co-authored-by: nicolas.schweitzer <nicolas.schweitzer@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants