Refactor daysInMonth to use lookup table for static values#16
Merged
Conversation
Replace the switch + chained || with an array lookup for the 10 months whose length is fixed, falling through to a direct dispatch for the 3 year-dependent months (CHESHVAN, KISLEV, ADAR_I).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactored the
daysInMonthfunction to improve readability and performance by using a lookup table for months with static day counts, while maintaining the same logic for variable-length months.Key Changes
STATIC_DAYS_IN_MONTHconstant array that maps each Hebrew month to its day count (0 indicates variable length)daysInMonthlogic by first checking the lookup table for static valuesImplementation Details
https://claude.ai/code/session_01VTWaREoLypCvHzEkkTWzWm