Update fitscore to use _strtoui64 on windows#142
Open
cruzzil wants to merge 2 commits into
Open
Conversation
esabol
reviewed
Jun 21, 2026
| if (*loc == '+') loc++; /* skip plus sign */ | ||
| while (isdigit(*loc)) loc++; /* skip digits */ | ||
|
|
||
| /* Microsoft Visual C++ does not have the strtoull function, but it |
Contributor
There was a problem hiding this comment.
Why did you change "strtoll" to "strtoull" in the comment here?
| provides _strtoui64, the unsigned 64-bit string conversion. This | ||
| correctly handles values above LLONG_MAX (unlike _atoi64) and sets | ||
| errno to ERANGE on overflow. */ | ||
| *ival = _strtoui64(cval, &loc, 10); |
Contributor
There was a problem hiding this comment.
Wouldn't _strtoi64 be the more appropriate function? Google says it was introduced all the way back in Microsoft Visual C++ 4.2 (released in 1996), and ffc2jj purports to "convert null-terminated formatted string to an [sic] long long integer value." So I think we want a long long, not an unsigned long long.
Contributor
Author
There was a problem hiding this comment.
Good spot, i pasted it in the wrong place. I've added a commit which fixes the call and also updates the following function which was the one I was trying to do!
esabol
approved these changes
Jun 22, 2026
esabol
left a comment
esabol
left a comment
Contributor
There was a problem hiding this comment.
OK, latest commit looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_strtoui64was available since MSVC 6.0 and looks like it is the logical choice. Shout if you think this is wrong.