Prompt for machine name at chezmoi init#5
Draft
hdp617 wants to merge 1 commit into
Draft
Conversation
Replace ~/.name content of darwin/linux with promptStringOnce machine_name, defaulting to .chezmoi.hostname. Used by tmux status bar and shell prompts. Co-authored-by: Huy Pham <hdp617@users.noreply.github.com>
There was a problem hiding this comment.
Code Review
This pull request introduces a new machine_name configuration option to the Chezmoi setup. It prompts the user for a machine name (defaulting to the hostname) in .chezmoi.toml.tmpl and updates dot_name.tmpl to use this value, falling back to the hostname if not defined. I have no feedback to provide as there are no review comments.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
~/.namewas templated todarwinorlinux, which is not useful for tmux status or shell prompts. This prompts for a human-readable machine name atchezmoi init, defaulting to the system hostname.Changes
machine_nameto chezmoi[data]viapromptStringOnce(default:.chezmoi.hostname).dot_name.tmplfrommachine_nameinstead of.chezmoi.os.Test plan
chezmoi initon a fresh machine (orchezmoi data set machine_name=...+chezmoi apply)~/.namecontains the chosen name