add configurable spotify login options and callback error handling - #7
Open
hd1801 wants to merge 1 commit into
Open
add configurable spotify login options and callback error handling#7hd1801 wants to merge 1 commit into
hd1801 wants to merge 1 commit into
Conversation
Support custom login scopes and show_dialog toggle in /login, and improve /callback handling for denied auth, missing code, token exchange failures, and network errors. Made-with: Cursor
![pr-governance-bot[bot]](https://avatars.githubusercontent.com/u/77338042?s=60&v=4){kind=small}
|
|
||
| // URLSearchParams#toString converts this object to a query string. | ||
| return res.redirect( | ||
| "https://accounts.spotify.com/authorize?" + |
There was a problem hiding this comment.
warning (code quality):
Hardcoded URL in login.js — use config or constant.
|
This PR has been open for 28 days and inactive for 23 days. Please update, request review, or close it if it is no longer needed. Thresholds: open for 3 days, inactive for 1 day. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support custom login scopes and show_dialog toggle in /login, and improve /callback handling for denied auth, missing code, token exchange failures, and network errors.
Made-with: Cursor