Skat - #64
Skat#64hsmajlovic wants to merge 3 commits into
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
@hsmajlovic I noticed that the PR was indicated to be merged into |
dinvlad
left a comment
dinvlad
left a comment
There was a problem hiding this comment.
Seems good, just a few minor comments.
Did you have a chance to test this code in dev yet, or do we need to merge the PRs first for that?
If it's the latter, I recommend merging sfkit-website and sfkit-react PRs first, and then you can test this sfkit CLI code without merging this PR first, to ensure it all works OK together with the real dev backend/frontend. Please let me know if you need help with that.
| config_path = os.path.join(constants.SFKIT_DIR, "skat_config.toml") | ||
| with open(config_path, "w") as f: | ||
| f.write(tomlkit.dumps(data)) | ||
|
|
||
| return config_path |
There was a problem hiding this comment.
Usually we have both configGlobal.toml for global params (that apply to all parties) and configLocal.Party{role}.toml for params specific to a given party.
I notice that https://github.com/swanhong/secure-skat seems to be using the same format (+ configPrepare.toml). Of course, just make sure it still works even with unified config format from above.
| if role == "1": | ||
| process_output_files(role) |
There was a problem hiding this comment.
Just to make sure, only role 1 needs processing output files?
3 participants
No description provided.