Secure skat preliminarily enabled - #76
Open
hsmajlovic wants to merge 1 commit into
Open
hsmajlovic wants to merge 1 commit into
hsmajlovic wants to merge 1 commit into
Conversation
dinvlad
approved these changes
Sep 10, 2026
dinvlad
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. One minor point is you might want to place SF-SKAT sections right after SF-RELATE, in order to logically group them with other SF- algorithms, rather than SF-RELATE -> Secure-DTI -> SF-SKAT.
On the other hand, we might want to preserve the order in which algos are added. So it's your call, wrt which way to arrange it.
Collaborator
There was a problem hiding this comment.
It might be good to add
// import sfskat from "../../static/images/sample_parameters/sfksat.png"; // TODOersatz at the beginning of the file right after the existing
// import securedti from "../../static/images/sample_parameters/securedti.png";so if you'd like to add a screenshot .png later it can be easier to find where it needs to be added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.