Skip to content

Secure skat preliminarily enabled - #76

Open
hsmajlovic wants to merge 1 commit into
prodfrom
skat
Open

hsmajlovic wants to merge 1 commit into
prodfrom
skat

Conversation

@hsmajlovic

Copy link
Copy Markdown
Member

No description provided.

@dinvlad dinvlad left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One minor point is you might want to place SF-SKAT sections right after SF-RELATE, in order to logically group them with other SF- algorithms, rather than SF-RELATE -> Secure-DTI -> SF-SKAT.

On the other hand, we might want to preserve the order in which algos are added. So it's your call, wrt which way to arrange it.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be good to add

// import sfskat from "../../static/images/sample_parameters/sfksat.png"; // TODO

ersatz at the beginning of the file right after the existing

// import securedti from "../../static/images/sample_parameters/securedti.png";

so if you'd like to add a screenshot .png later it can be easier to find where it needs to be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants