Skip to content

Edge: fail when the tag stays on an old commit; changelog for 1.6.1 #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hbenabdallah merged 2 commits into from
Nov 7, 2026
Merged

Edge: fail when the tag stays on an old commit; changelog for 1.6.1 #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c67127
Edge: fail when the tag stays on an old commit; changelog for 1.6.1
hbenabdallah Nov 7, 2026
dddebdb
Edge: retry reading the tag; changelog: any "param" literal, not a pa…
hbenabdallah Nov 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions .github/workflows/edge.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,24 @@ jobs:
fi
if gh release create edge dist/* --prerelease --target "$GITHUB_SHA" --title "dev-main" \
--notes "Built from main at $GITHUB_SHA. Not a release: install a version for production use."; then
exit 0
published=1
break
fi
sleep 20
done
exit 1
test -n "${published:-}"
# gh reuses an existing tag and ignores --target: when the old tag could not be deleted (a tag ruleset refuses it,
# "Cannot delete this tag" above), the release is published on the old commit and nothing else fails.
- name: Check that the edge tag moved to this commit
env:
GH_TOKEN: ${{ github.token }}
GH_REPO: ${{ github.repository }}
run: |
for _ in 1 2 3; do
tagged=$(gh api "repos/$GH_REPO/commits/edge" --jq .sha) && break
sleep 20
done
if [ "${tagged:-}" != "$GITHUB_SHA" ]; then
echo "::error::The edge tag points to ${tagged:-an unreadable commit}, not $GITHUB_SHA: exclude refs/tags/edge from the repository's tag ruleset."
exit 1
fi
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,13 @@ phpgraph follows [semantic versioning](https://semver.org) from 1.0.0; what stay
the files a build reuses. Docker image, 12-thread laptop: Sylius 28 → 10 s, Akeneo 26 → 17 s; with the cache of
the previous build, Sylius 14 → 8 s. Peak memory +12 to +20 % with workers, −4 to −28 % without.

## 1.6.1 (2026-10-30)

### Fixed
- A call to a configuration helper with the string `"param"` among its arguments was taken for a call depending on
its caller's parameters, so it was never evaluated and the services it declares were missing. The rest of 1.6.1 is
internal (the AGENTS.md rules applied to `src/`): every graph of the corpus is identical to 1.6.0's.

## 1.6.0 (2026-10-30)

### Added
Expand Down
Loading