Skip to content

Apply the AGENTS.md rules to src/ - #14

Merged
hbenabdallah merged 1 commit into
mainfrom
refactor/agents-rules
Oct 30, 2026
Merged

hbenabdallah merged 1 commit into
mainfrom
refactor/agents-rules

Conversation

@hbenabdallah

Copy link
Copy Markdown
Owner
  • No nested ternaries, conditional array unions or assignments in conditions (helpers named after what they compute).
  • Exact PHPDoc shapes instead of array<string, mixed> (toArray(), MCP responses, container config cache); boundary data stays open.
  • Recursive structures as final readonly objects: conditional return types (ConditionalReturn…) and configuration-helper templates (Template, Service*Fact, PendingHelperCall…).
  • Fix: a literal argument "param" was taken for a helper parameter, so that call was never evaluated.

Outputs identical to main on 6 corpus projects, NextAPI and jac2-web (graph, report, overview, outline/impact/query in text, full and JSON, mcp-config, MCP session). composer check green, 2 new tests.

Corpus (11 projects): every count identical to the baseline. Build time on par with main in an A/B on the same machine (Sylius 20.2 → 19.6 s, Akeneo 31.0 → 29.9 s, median of 3); memory unchanged.

…shapes, recursive structures as readonly objects
@hbenabdallah
hbenabdallah merged commit b552ab0 into main Oct 30, 2026
8 checks passed
@hbenabdallah
hbenabdallah deleted the refactor/agents-rules branch October 30, 2026 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant