Prevent stale release artifacts - #3
Draft
potpiemuncher wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NUGET_USERis not configuredRoot cause
The v0.0.5 tag workflow built the correct artifacts, but the
create-releasejob attempted all external package publication first. The job stopped at
NuGet/login@v1.2.0becauseNUGET_USERwas not configured, so the GitHubrelease step never ran.
The subsequently published Windows release asset reports
v0.0.3-18-g02fffe6, while the Windows artifact retained by the failed tag runreports
v0.0.5(FileVersion 0.0.5.0). Preserving the verified GitHub draftbefore optional registry work prevents the correct binaries from being stranded
again, while registry failures remain visible in the workflow result.
Failed run: https://github.com/hbashton/VIIPER/actions/runs/30057594001
Impact
Release artifacts are now checked against the tag and attached to a draft
GitHub release before external registries can fail. Repositories that do not
publish the C# package can omit
NUGET_USERwithout blocking the other releasework.
Validation
actionlint1.7.7 in Docker: passedgo test ./...ingolang:1.26-bookworm: passedartifact: accepted
v0.0.5v9.9.9: rejected the artifactwith a nonzero exit