Update Eff to make it work with GHC 9.6#17
Open
s-and-witch wants to merge 1 commit intohasura:masterfrom
Open
Conversation
Problem:
Delcont api used in the library incompalible with the one
implemented in upstream GHC, so eff just doesn't compile
Solution:
Previous primitive semantic was build in that each control0#
captures continuation to nearest prompt#, so having one PromptTag#
for all prompt#'s seems to be a simple drop-in replacement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Delcont API used in the library, incompatible with the one
implemented in upstream GHC, so eff just doesn't compile
Solution:
Previous primitive semantic was build in that each
control0#captures continuation to nearest
prompt#, so having onePromptTag#for all
prompt#'s seems to be a simple drop-in replacement.Please tell me if this patch violates library or RTS semantics.