Fix: NullReferenceException in Satellite Service on unknown types#441
Merged
amadeo-alex merged 1 commit intoMar 22, 2026
Merged
Conversation
…avoids a NullReferenceException when the Satellite Service encounters unsupported entity types (e.g. WebViewCommand, Bluetooth sensors) that aren't available in the headless service context.
Collaborator
|
Now I wonder what kind of sneakery you were up to to find this :D Jokes aside the entity initialisation code is not up to "standard" - will be fixed with the full rewrite tho. Looks good, gonna double check the files before merging and make it part of 2.2.1 (should have some time next week to push it out). |
amadeo-alex
approved these changes
Mar 22, 2026
amadeo-alex
changed the title
Author
found this because i had non-satellite items in my satellite configs (basically #442) |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Satellite Service currently crashes with a NullReferenceException if the configuration contains entity types it doesn't support (like WebView commands or Bluetooth sensors). This happens because the conversion logic returns null but the caller still adds it to the active collection and later tries to publish it. This PR adds null checks to safely skip these unknown types. Without the fix it gives no indication to the user that something went wrong and instead constantly fails silently in the service logs.