Reconnect without notification#345
Open
larena1 wants to merge 1 commit into
Open
Conversation
amadeo-alex
reviewed
Sep 18, 2025
amadeo-alex
left a comment
amadeo-alex
left a comment
Collaborator
There was a problem hiding this comment.
had a few minutes to run down through the code and added comments on what caught my eye
amadeo-alex
reviewed
Sep 27, 2025
Author
|
Hi @amadeo-alex |
Collaborator
|
? |
Author
|
I was waiting for your response to that and if you want to proceed with this general overhaul of the reconnect logic after all your feedback is addressed or if you want to take another approach on it. |
Collaborator
|
I'd prefer to leave both notifications, this is however not a big issue/discussion as worst case scenario the notification can be unified. The bigger issue is the UI option that would do nothing. |
larena1
force-pushed
the
fix-notification
branch
2 times, most recently
from
0c9bc7b to
cf84726
Compare
larena1
force-pushed
the
fix-notification
branch
from
cf84726 to
cd2a560
Compare
Author
|
@amadeo-alex I've made the changes you requested and hope this works for you now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.