Skip to content

Fix semantic tokens dynamic registration and CantRegister log #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fendor merged 1 commit into from
Mar 23, 2026
+5 −4
Merged

Fix semantic tokens dynamic registration and CantRegister log #635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions lsp-types/src/Language/LSP/Protocol/Capabilities.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,9 +298,10 @@ dynamicRegistrationSupported m caps = fromMaybe False $ case m of
SMethod_TextDocumentMoniker -> caps ^? dyn m
SMethod_TextDocumentPrepareTypeHierarchy -> caps ^? dyn m
SMethod_TextDocumentDiagnostic -> caps ^? dyn m
-- semantic tokens is messed up due to it having you register with an otherwise non-existent method
-- SMethod_TextDocumentSemanticTokens -> capDyn $ clientCaps ^? L.textDocument . _Just . L.semanticTokens . _Just
-- Notebook document methods alway support dynamic registration, it seems?
SMethod_TextDocumentSemanticTokensFull -> caps ^? dyn m
SMethod_TextDocumentSemanticTokensFullDelta -> caps ^? dyn m
SMethod_TextDocumentSemanticTokensRange -> caps ^? dyn m
-- Notebook document methods always support dynamic registration, it seems?
_ -> Just False
where
dyn :: L.HasDynamicRegistration (ClientCapability m) (Maybe Bool) => SMethod m -> Traversal' ClientCapabilities Bool
Expand Down
2 changes: 1 addition & 1 deletion lsp/src/Language/LSP/Server/Core.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,7 +620,7 @@ trySendRegistration logger method regOpts = do

pure (Just $ RegistrationToken method regId)
else do
logger <& CantRegister SMethod_WorkspaceDidChangeConfiguration `WithSeverity` Warning
logger <& CantRegister method `WithSeverity` Warning
pure Nothing

{- | Sends a @client/unregisterCapability@ request and removes the handler
Expand Down
Loading