Skip to content

ci(mergify): upgrade configuration to current format#10978

Merged
mergify[bot] merged 1 commit intomasterfrom
mergify/configuration-deprecated-update
Apr 18, 2026
Merged

ci(mergify): upgrade configuration to current format#10978
mergify[bot] merged 1 commit intomasterfrom
mergify/configuration-deprecated-update

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Jun 7, 2025

No more deprecated fields are being used in your Mergify configuration, this pull request will be closed.

@geekosaur
Copy link
Copy Markdown
Collaborator

I knew it.

@geekosaur
Copy link
Copy Markdown
Collaborator

To: support@mergify.com
Subject: your upgrade notifier really doesn't like our configuration

I'm a member of the Cabal support team. Your bot keeps complaining about our config, but ignoring most of it when "fixing" it. We just received a third "here, I'vve fixed your queue rules" PR that for the third time ignored one of our rules and broke the other. Is there a way to make it happy while keeping our configuration?

Configuration: https://github.com/haskell/cabal/blob/master/.github/mergify.yml
Broken "fix": https://github.com/haskell/cabal/pull/10978/files

The "fix" ignores the squash-merge queue and continually raises the priority of the default queue over the priority of the direct-to-release-branch rule, which is deliberately higher than the default.

@geekosaur geekosaur marked this pull request as draft June 7, 2025 19:55
@ulysses4ever
Copy link
Copy Markdown
Collaborator

@geekosaur did you send the above message somewhere or is it a draft for comments?

@geekosaur
Copy link
Copy Markdown
Collaborator

I sent it, we had a few rounds, the conclusion was that we should just let it sit and they're submitting an internal ticket (but I expect that won't go anywhere since the cutoff will pass first).

@geekosaur
Copy link
Copy Markdown
Collaborator

From: Guillaume at Mergify

Hello, thanks for the report.
The automatic configuration upgrade is mostly a way to warn you about upcoming deprecations, if you don't care about the changes or already fixed your config for the upcoming deprecation then you can just ignore the pull request.

I'll create a ticket on our side to try to fix this issue.
From: geekosaur

https://github.com/haskell/cabal/pull/10921#event-17466617338 made it sound like not….
From: Guillaume at Mergify

The configuration upgrade system is trying to be as generic as possible, that's why some edge case might not be properly handled. As long as your current configuration fits your needs after the deprecation, you can ignore the pull request. It will be automatically closed once the deprecated parts' support has been fully removed, which is near the 30th of June for this case.
I have created a ticket on our side to try to improve the upgrade system.

@ulysses4ever
Copy link
Copy Markdown
Collaborator

Great, thank you!

Let it sit was my proposal as well.

@mergify mergify bot force-pushed the mergify/configuration-deprecated-update branch from 0bfe03a to 1e49754 Compare June 27, 2025 16:52
@geekosaur
Copy link
Copy Markdown
Collaborator

Of course they just reverted my attempt to keep it from breaking our setup…

@mergify mergify bot force-pushed the mergify/configuration-deprecated-update branch from 1e49754 to b748a11 Compare April 16, 2026 10:44
@geekosaur geekosaur closed this Apr 16, 2026
@geekosaur
Copy link
Copy Markdown
Collaborator

Still no indication that this (a) does anything but break our priorities (b) is going to be fixed. I won't be surprised if another one gets opened within an hour or so that still breaks things to no point.

@mergify mergify bot reopened this Apr 16, 2026
@mergify mergify bot force-pushed the mergify/configuration-deprecated-update branch from 3b1afe1 to b748a11 Compare April 16, 2026 16:01
@geekosaur
Copy link
Copy Markdown
Collaborator

Oh, it seems to have one actual change that looks valid now. And isn't breaking priorities any more.

@geekosaur geekosaur added merge me Tell Mergify Bot to merge and removed attention: needs-review labels Apr 16, 2026
@mergify mergify bot added ready and waiting Mergify is waiting out the cooldown period merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days queued labels Apr 16, 2026
@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented Apr 18, 2026

Merge Queue Status

This pull request spent 1 hour 52 minutes 11 seconds in the queue, including 1 hour 40 minutes 43 seconds running CI.

Required conditions to merge
  • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = Doctest Cabal
    • check-neutral = Doctest Cabal
    • check-skipped = Doctest Cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Meta checks
    • check-neutral = Meta checks
    • check-skipped = Meta checks
  • any of [🛡 GitHub branch protection]:
    • check-success = docs/readthedocs.org:cabal
    • check-neutral = docs/readthedocs.org:cabal
    • check-skipped = docs/readthedocs.org:cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Validate post job
    • check-neutral = Validate post job
    • check-skipped = Validate post job
  • any of [🛡 GitHub branch protection]:
    • check-success = fourmolu
    • check-neutral = fourmolu
    • check-skipped = fourmolu
  • any of [🛡 GitHub branch protection]:
    • check-success = hlint
    • check-neutral = hlint
    • check-skipped = hlint
  • any of [🛡 GitHub branch protection]:
    • check-success = Bootstrap post job
    • check-neutral = Bootstrap post job
    • check-skipped = Bootstrap post job
  • any of [🛡 GitHub branch protection]:
    • check-success = whitespace
    • check-neutral = whitespace
    • check-skipped = whitespace
  • any of [🛡 GitHub branch protection]:
    • check-success = Check sdist post job
    • check-neutral = Check sdist post job
    • check-skipped = Check sdist post job
  • any of [🛡 GitHub branch protection]:
    • check-success = Changelogs
    • check-neutral = Changelogs
    • check-skipped = Changelogs

mergify bot added a commit that referenced this pull request Apr 18, 2026
@mergify mergify bot merged commit ab92bf0 into master Apr 18, 2026
345 of 348 checks passed
@mergify mergify bot deleted the mergify/configuration-deprecated-update branch April 18, 2026 21:46
@mergify mergify bot removed the queued label Apr 18, 2026
@ulysses4ever
Copy link
Copy Markdown
Collaborator

@geekosaur why did we merge this? I thought it only breaks things for us...

@geekosaur
Copy link
Copy Markdown
Collaborator

#10978 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

continuous-integration merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants