Skip to content

Replace confusing "route" record parameter in favour of "mode" #1882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tchoutri merged 1 commit into from
May 8, 2026
+6 −6
Merged

Replace confusing "route" record parameter in favour of "mode" #1882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions servant/src/Servant/API/Generic.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@
-- define a record with field types prefixed by a parameter `route`:
--
-- @
-- data Routes route = Routes
-- { _get :: route :- Capture "id" Int :> Get '[JSON] String
-- , _put :: route :- ReqBody '[JSON] Int :> Put '[JSON] Bool
-- data Routes mode = Routes
-- { _get :: mode :- Capture "id" Int :> Get '[JSON] String
-- , _put :: mode :- ReqBody '[JSON] Int :> Put '[JSON] Bool
-- }
-- deriving ('Generic')
-- @
Expand Down
6 changes: 3 additions & 3 deletions servant/src/Servant/Links.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,9 +374,9 @@ allLinks' toA api = toLink toA api (Link mempty mempty mempty)
-- type is used.
--
-- @
-- data Record route = Record
-- { _get :: route :- Capture "id" Int :> Get '[JSON] String
-- , _put :: route :- ReqBody '[JSON] Int :> Put '[JSON] Bool
-- data Record mode = Record
-- { _get :: mode :- Capture "id" Int :> Get '[JSON] String
-- , _put :: mode :- ReqBody '[JSON] Int :> Put '[JSON] Bool
-- }
-- deriving ('Generic')
--
Expand Down
Loading